Skip to content

feat: add cli entrypoint and fat jar to use standalone#149

Merged
ruromero merged 5 commits into
guacsec:mainfrom
ruromero:feat/cli
Jul 22, 2025
Merged

feat: add cli entrypoint and fat jar to use standalone#149
ruromero merged 5 commits into
guacsec:mainfrom
ruromero:feat/cli

Conversation

@ruromero

@ruromero ruromero commented Jul 18, 2025

Copy link
Copy Markdown
Collaborator

Description

Generate a fat jar with cli suffix
Add a default entrypoint (Cli.java) that accepts some arguments in order to execute the analysis standalone

Related issue (if any): fixes #148

Checklist

  • I have followed this repository's contributing guidelines.
  • I will adhere to the project's code of conduct.

@ruromero ruromero requested a review from soul2zimate July 18, 2025 14:13
soul2zimate
soul2zimate requested changes Jul 21, 2025
View reviewed changes

@soul2zimate soul2zimate left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ruromero, Overall this looks good to me, please check my one small comment and the CI failure.

Please either add a test or reduce Jacoco ratio at line https://github.com/trustification/exhort-java-api/blob/main/pom.xml#L16 or maybe exclude Cli.java for Jacoco.

Thanks.

Comment thread src/main/java/com/redhat/exhort/Cli.java Outdated
@ruromero

ruromero commented Jul 21, 2025

Copy link
Copy Markdown
Collaborator Author

Hi @ruromero, Overall this looks good to me, please check my one small comment and the CI failure.

Please either add a test or reduce Jacoco ratio at line https://github.com/trustification/exhort-java-api/blob/main/pom.xml#L16 or maybe exclude Cli.java for Jacoco.

Thanks.

I have done some refactoring to also allow mocking some methods and then I added tests to cover all the added code

@ruromero ruromero force-pushed the feat/cli branch 2 times, most recently from f41b088 to cb5de93 Compare July 21, 2025 13:16
@ruromero

ruromero commented Jul 21, 2025

Copy link
Copy Markdown
Collaborator Author

@soul2zimate ready to review again when you have time. Thanks

@soul2zimate

soul2zimate commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

LGTM Thanks @ruromero

ruromero added 5 commits July 22, 2025 08:21
@ruromero
feat: add cli entrypoint and fat jar to use standalone
c6dd451 
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
@ruromero
feat: added tests and refactor App.java
f524e7d 
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
@ruromero
feat: update entrypoint and shade plugin config
ff8528f 
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
@ruromero
chore: add better test coverage
529ba73 
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
@ruromero
docs: update license header
30209d8 
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
@ruromero ruromero enabled auto-merge (squash) July 22, 2025 06:22
@ruromero ruromero merged commit 8a8a643 into guacsec:main Jul 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soul2zimate soul2zimate soul2zimate approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for CLI execution

2 participants

@ruromero @soul2zimate